Skip to content

[None][fix] Waive test_nemotron_h_breakable_prefill_cuda_graph[ray-tp1] - #19355

Closed
farazkh80 wants to merge 1 commit into
NVIDIA:mainfrom
farazkh80:fix_waive_nemotron_h_ray_tp1
Closed

farazkh80 wants to merge 1 commit into
NVIDIA:mainfrom
farazkh80:fix_waive_nemotron_h_ray_tp1

Conversation

@farazkh80

@farazkh80 farazkh80 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Description

test_nemotron_h_breakable_prefill_cuda_graph is marked @pytest.mark.mpi_ray_parity, which adds a separate ray_mode parametrization when CI runs with --run-ray (tests/unittest/conftest.py), producing a distinct test id [ray-tp1] alongside the base [tp1]. Waive matching in apply_waives() (tests/integration/defs/test_list_parser.py) is an exact nodeid match with no wildcard support, so the existing waive for [tp1] (nvbugs/6777501) does not cover [ray-tp1]. This is currently failing the H100_PCIe-PyTorch-Ray-1 CI stage on PR #19038 as an unrelated pre-existing issue.

Changes

  • Add a matching waive entry for [ray-tp1], same nvbug.

Open question

I have not confirmed that nvbugs/6777501 covers the Ray-executor code path specifically, only that the assertion text is identical to the MPI variant. If the Ray path turns out to have a distinct root cause, this waive should be revisited.

PR Checklist

  • I have read the Contributing Guidelines.
  • I have run pre-commit run --all-files and fixed any issues.
  • I have added tests for my changes or explained why they are not needed above.

Dev Engineer Review

Adds an exact waiver for the Ray-specific test ID under NV bug 6777501. The existing [tp1] waiver remains separate. Scope is limited to the reported CI failure.

QA Engineer Review

Modifies only tests/integration/test_lists/waives.txt. It adds the ray-tp1 waiver; the existing tp1 waiver remains present. No test execution results are supplied. Coverage verdict: needs follow-up.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Verify that the exact ray-tp1 entry suppresses only the intended test and does not affect other parametrizations. No separate CI or manual-QA list change applies to this waiver-only update.

The mpi_ray_parity marker on this test adds a separate ray_mode
parametrization when CI runs with --run-ray, producing a distinct
test id (test_nemotron_h_breakable_prefill_cuda_graph[ray-tp1]) that
the existing waive entry for [tp1] (https://nvbugs/6777501) does not
cover, since waive matching is an exact nodeid match with no wildcard
support. Add the matching [ray-tp1] entry so the Ray-executor variant
of this known failure is waived too.

Signed-off-by: farazkh80 <58580514+farazkh80@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 38072ad6-b20f-4efe-bab7-9e0af81e1c53

📥 Commits

Reviewing files that changed from the base of the PR and between ffeb88c and 3148df8.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The skipped test list adds the Ray/Tensor-Parallel-1 Nemotron-H breakable-prefill CUDA-graph test, tracked by NV bug 6777501.

Changes

Nemotron-H test waiver

Layer / File(s) Summary
Add skipped test entry
tests/integration/test_lists/waives.txt
Adds the Ray/Tensor-Parallel-1 Nemotron-H breakable-prefill CUDA-graph test to the skipped tests list.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: brnguyen2

Merge Risk: ⚪ Minimal · up to 3148d

This narrowly scoped test waiver is mergeable with no outstanding actionable risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required [None][fix] format and clearly identifies the added waiver for the Ray-specific test.
Description check ✅ Passed The description explains the issue, the exact node ID mismatch, the solution, the related NV bug, and the test validation. It does not include a separate Test Coverage section, but it explains why no …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@farazkh80 farazkh80 closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant