Skip to content

[None][infra] Fix release check failure for .test_durations#16784

Open
EmmaQiaoCh wants to merge 6 commits into
NVIDIA:mainfrom
EmmaQiaoCh:emma/fix_release_check
Open

[None][infra] Fix release check failure for .test_durations#16784
EmmaQiaoCh wants to merge 6 commits into
NVIDIA:mainfrom
EmmaQiaoCh:emma/fix_release_check

Conversation

@EmmaQiaoCh

@EmmaQiaoCh EmmaQiaoCh commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

@coderabbitai summary

Description

To fix the format for .test_duration and also fix it in the generate script.
Failed job: https://prod.blsm.nvidia.com/sw-tensorrt-top-1/blue/organizations/jenkins/LLM%2Fmain%2FL0_PostMerge/detail/L0_PostMerge/2855/pipeline/268/

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
@EmmaQiaoCh

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The duration generator now appends a trailing newline to its JSON output. The Jenkins shell script and checked-in duration fixture were updated to reflect the resulting file formatting.

Changes

Duration file formatting

Layer / File(s) Summary
Duration file output formatting
jenkins/scripts/generate_duration.py, jenkins/UpdateTestDurations.groovy, tests/integration/defs/.test_durations
The generator writes a trailing newline, the pipeline script gains a blank line, and the fixture’s closing brace is placed on the final line.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: trtllm-agent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the change set and follows the repository's [None][infra] style.
Description check ✅ Passed The description explains the issue and fix, but the Test Coverage section is left blank.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61228 [ run ] triggered by Bot. Commit: 743f03c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61228 [ run ] completed with state FAILURE. Commit: 743f03c
/LLM/main/L0_MergeRequest_PR pipeline #49467 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@EmmaQiaoCh

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61236 [ run ] triggered by Bot. Commit: 743f03c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61236 [ run ] completed with state SUCCESS. Commit: 743f03c
/LLM/main/L0_MergeRequest_PR pipeline #49475 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants