[None][infra] Fix release check failure for .test_durations#16784
[None][infra] Fix release check failure for .test_durations#16784EmmaQiaoCh wants to merge 6 commits into
Conversation
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
|
/bot run |
WalkthroughThe duration generator now appends a trailing newline to its JSON output. The Jenkins shell script and checked-in duration fixture were updated to reflect the resulting file formatting. ChangesDuration file formatting
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #61228 [ run ] triggered by Bot. Commit: |
|
PR_Github #61228 [ run ] completed with state
|
|
/bot run |
|
PR_Github #61236 [ run ] triggered by Bot. Commit: |
|
PR_Github #61236 [ run ] completed with state
|
@coderabbitai summary
Description
To fix the format for .test_duration and also fix it in the generate script.
Failed job: https://prod.blsm.nvidia.com/sw-tensorrt-top-1/blue/organizations/jenkins/LLM%2Fmain%2FL0_PostMerge/detail/L0_PostMerge/2855/pipeline/268/
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.