Skip to content

[https://nvbugs/6114727][fix] Unwaive deepseek r1 fp4 v2 grace_blackwell r1 fp4 v2 tep4 mtp3 1k1k#13496

Open
chenfeiz0326 wants to merge 1 commit intoNVIDIA:mainfrom
chenfeiz0326:chenfeiz/unwaive-r1_fp4_v2_tep4_mtp3_1k1k-con32_iter10_1k1k
Open

[https://nvbugs/6114727][fix] Unwaive deepseek r1 fp4 v2 grace_blackwell r1 fp4 v2 tep4 mtp3 1k1k#13496
chenfeiz0326 wants to merge 1 commit intoNVIDIA:mainfrom
chenfeiz0326:chenfeiz/unwaive-r1_fp4_v2_tep4_mtp3_1k1k-con32_iter10_1k1k

Conversation

@chenfeiz0326
Copy link
Copy Markdown
Collaborator

@chenfeiz0326 chenfeiz0326 commented Apr 27, 2026

Summary by CodeRabbit

  • Tests
    • A previously excluded integration test is now included in the test suite, improving test coverage for performance sanity checks.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

📝 Walkthrough

Walkthrough

A single line is removed from the integration test waiver list, which previously exempted a specific performance test case from running. The test case is now allowed to execute without exclusion.

Changes

Cohort / File(s) Summary
Integration Test Waiver List
tests/integration/test_lists/waives.txt
Removed exemption entry for perf/test_perf_sanity.py::test_e2e test case under the aggr_upload-deepseek_r1_fp4_v2_grace_blackwell-...-mtp3_1k1k configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description consists only of the template with placeholders unfilled. Critical sections like Description, Test Coverage are empty, and the PR checklist is marked as complete without substantive content. Fill in the Description section explaining why the test waiver is being removed and the Test Coverage section listing relevant tests. Complete the PR checklist sections with concrete details about what was verified.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly specifies the purpose of the PR: removing a waiver for a specific test configuration (deepseek r1 fp4 v2 grace_blackwell), which directly aligns with the changeset that removes one line from waives.txt.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@chenfeiz0326 chenfeiz0326 changed the title [https://nvbugs/6114727][fix] Unwaive deepseek_r1_fp4_v2_grace_blackwell-r1_fp4_v2_tep4_mtp3_1k1k [https://nvbugs/6114727][fix] Unwaive deepseek r1 fp4 v2 grace_blackwell r1 fp4 v2 tep4 mtp3 1k1k Apr 27, 2026
@chenfeiz0326
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #45678 [ run ] triggered by Bot. Commit: b92380e Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #45678 [ run ] completed with state FAILURE. Commit: b92380e
/LLM/main/L0_MergeRequest_PR pipeline #35886 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants