[https://nvbugs/6114711][fix] Add "kimi_k2": "kimi_k2" and "kimi_k25": "kimi_k2" to `MODEL_TYPE_TO_REASONI#13490
Open
tensorrt-cicd wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
…etection Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes add support for two additional model types, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MODEL_TYPE_TO_REASONING_PARSERdict was missing entries forkimi_k2andkimi_k25model types, soresolve_auto_reasoning_parser()returnedNoneand no reasoning parser was applied, causing<think>...</think>content to be returned verbatim in the response."kimi_k2": "kimi_k2"and"kimi_k25": "kimi_k2"toMODEL_TYPE_TO_REASONING_PARSERdict, and update the error message inserve.pyto list these model types.Test plan
Links
Summary by CodeRabbit
kimi_k2andkimi_k25model types in reasoning parser auto-detection functionality.