[None][test] Waive 4 failed cases for main in QA CI#13456
[None][test] Waive 4 failed cases for main in QA CI#13456xinhe-nv wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
2656582 to
3940ff9
Compare
Bug(s): 6105765, 6106174, 6112497, 6112500 Requested by: qa@nvidia.com Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2118/ Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
3940ff9 to
c475b11
Compare
📝 WalkthroughWalkthroughTwo test cases are waived in the integration test waiver list: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 423-424: The waive list is missing two entries referenced in the
PR description; add two lines for the
TestGemma3_1BInstruct::test_fp8_prequantized[...] tests corresponding to bug IDs
6106174 and 6105765 in tests/integration/test_lists/waives.txt, matching the
existing format (test identifier followed by "SKIP (https://nvbugs/<bug>)") so
they appear alongside the existing two SKIP entries for the other tests; ensure
the test name exactly matches "TestGemma3_1BInstruct::test_fp8_prequantized"
with the appropriate bracketed variant tags used in the PR description.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9f16a9cf-0d59-4f7d-aa48-fb39a4e20354
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
| accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500) | ||
| accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497) |
There was a problem hiding this comment.
PR objective says 4 waives, but this patch adds only 2.
Line 423 and Line 424 look valid, but the two TestGemma3_1BInstruct::test_fp8_prequantized[...] waives from the PR description are still missing in tests/integration/test_lists/waives.txt (bugs 6106174 and 6105765). Please add those two entries as well, otherwise this waive PR appears incomplete.
Suggested patch
accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500)
accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497)
+accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=False] SKIP (https://nvbugs/6106174)
+accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=True] SKIP (https://nvbugs/6105765)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500) | |
| accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497) | |
| accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500) | |
| accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497) | |
| accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=False] SKIP (https://nvbugs/6106174) | |
| accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=True] SKIP (https://nvbugs/6105765) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tests/integration/test_lists/waives.txt` around lines 423 - 424, The waive
list is missing two entries referenced in the PR description; add two lines for
the TestGemma3_1BInstruct::test_fp8_prequantized[...] tests corresponding to bug
IDs 6106174 and 6105765 in tests/integration/test_lists/waives.txt, matching the
existing format (test identifier followed by "SKIP (https://nvbugs/<bug>)") so
they appear alongside the existing two SKIP entries for the other tests; ensure
the test name exactly matches "TestGemma3_1BInstruct::test_fp8_prequantized"
with the appropriate bracketed variant tags used in the PR description.
|
/bot run --skip-test |
|
PR_Github #45624 [ run ] triggered by Bot. Commit: |
|
PR_Github #45624 [ run ] completed with state |
|
merge to #13504 |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainJenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2118/
Bug(s): 6112497, 6112500
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit