Skip to content

[None][test] Waive 4 failed cases for main in QA CI#13456

Closed
xinhe-nv wants to merge 1 commit intoNVIDIA:mainfrom
xinhe-nv:trtllm-ci-report/waive-20260425-021903
Closed

[None][test] Waive 4 failed cases for main in QA CI#13456
xinhe-nv wants to merge 1 commit intoNVIDIA:mainfrom
xinhe-nv:trtllm-ci-report/waive-20260425-021903

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Apr 25, 2026

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch: main
Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2118/
Bug(s): 6112497, 6112500

Waive entries added

accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500)
accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Updated test waiver list to exclude specific test configurations that are currently skipped during integration testing.

@crazydemo crazydemo force-pushed the trtllm-ci-report/waive-20260425-021903 branch from 2656582 to 3940ff9 Compare April 27, 2026 02:19
@crazydemo crazydemo marked this pull request as ready for review April 27, 2026 02:25
Bug(s): 6105765, 6106174, 6112497, 6112500
Requested by: qa@nvidia.com
Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST/2118/

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@crazydemo crazydemo force-pushed the trtllm-ci-report/waive-20260425-021903 branch from 3940ff9 to c475b11 Compare April 27, 2026 02:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

📝 Walkthrough

Walkthrough

Two test cases are waived in the integration test waiver list: TestNemotronNanoV3::test_accuracy with fp8-4 and trtllm, and TestLlama3_1_8BInstruct::test_bfloat16_4gpus with pp4 and specific settings, each linked to an nvbugs tracker URL.

Changes

Cohort / File(s) Summary
Test Waiver List
tests/integration/test_lists/waives.txt
Added two waive entries for TestNemotronNanoV3::test_accuracy (fp8-4, trtllm) and TestLlama3_1_8BInstruct::test_bfloat16_4gpus (pp4, TRTLLM backend, torch_compile=False), each with corresponding nvbugs references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jieli-matrix
  • StanleySun639
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description lacks required sections from template including detailed explanation of changes, test coverage details, and completion of PR checklist. Add comprehensive sections covering: (1) detailed description of why waivers are needed, (2) test coverage explanation, (3) completed PR checklist confirming alignment with coding guidelines and required reviews.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][test] Waive 4 failed cases for main in QA CI' directly describes the main change: waiving failed test cases for the main branch in QA CI, matching the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 423-424: The waive list is missing two entries referenced in the
PR description; add two lines for the
TestGemma3_1BInstruct::test_fp8_prequantized[...] tests corresponding to bug IDs
6106174 and 6105765 in tests/integration/test_lists/waives.txt, matching the
existing format (test identifier followed by "SKIP (https://nvbugs/<bug>)") so
they appear alongside the existing two SKIP entries for the other tests; ensure
the test name exactly matches "TestGemma3_1BInstruct::test_fp8_prequantized"
with the appropriate bracketed variant tags used in the PR description.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9f16a9cf-0d59-4f7d-aa48-fb39a4e20354

📥 Commits

Reviewing files that changed from the base of the PR and between 035de5d and 3940ff9.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment on lines +423 to +424
accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500)
accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

PR objective says 4 waives, but this patch adds only 2.

Line 423 and Line 424 look valid, but the two TestGemma3_1BInstruct::test_fp8_prequantized[...] waives from the PR description are still missing in tests/integration/test_lists/waives.txt (bugs 6106174 and 6105765). Please add those two entries as well, otherwise this waive PR appears incomplete.

Suggested patch
 accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500)
 accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497)
+accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=False] SKIP (https://nvbugs/6106174)
+accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=True] SKIP (https://nvbugs/6105765)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500)
accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497)
accuracy/test_llm_api_autodeploy.py::TestNemotronNanoV3::test_accuracy[fp8-4-trtllm] SKIP (https://nvbugs/6112500)
accuracy/test_llm_api_pytorch.py::TestLlama3_1_8BInstruct::test_bfloat16_4gpus[pp4-attn_backend=TRTLLM-torch_compile=False] SKIP (https://nvbugs/6112497)
accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=False] SKIP (https://nvbugs/6106174)
accuracy/test_llm_api_pytorch.py::TestGemma3_1BInstruct::test_fp8_prequantized[torch_compile=True] SKIP (https://nvbugs/6105765)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@tests/integration/test_lists/waives.txt` around lines 423 - 424, The waive
list is missing two entries referenced in the PR description; add two lines for
the TestGemma3_1BInstruct::test_fp8_prequantized[...] tests corresponding to bug
IDs 6106174 and 6105765 in tests/integration/test_lists/waives.txt, matching the
existing format (test identifier followed by "SKIP (https://nvbugs/<bug>)") so
they appear alongside the existing two SKIP entries for the other tests; ensure
the test name exactly matches "TestGemma3_1BInstruct::test_fp8_prequantized"
with the appropriate bracketed variant tags used in the PR description.

@crazydemo
Copy link
Copy Markdown
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #45624 [ run ] triggered by Bot. Commit: c475b11 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #45624 [ run ] completed with state SUCCESS. Commit: c475b11
/LLM/main/L0_MergeRequest_PR pipeline #35837 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@crazydemo
Copy link
Copy Markdown
Collaborator

merge to #13504

@crazydemo crazydemo closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants