fix(pe3): distinguish OAuth token nouns from access actions - #392
Merged
Conversation
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
marked this pull request as ready for review
August 18, 2026 10:11
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
access token/access tokensterminology in documentation without relying on a small OAuth lifecycle allowlistRoot cause
PE3's generic
access ... tokens?expression cannot distinguish the verb phrase “access tokens” from the compound noun “access token.” The existing documentation exception required a narrow lifecycle keyword and modifier list, so glossary entries, OAuth return values, revocation behavior, storage guidance, and supported-token tables still surfaced as HIGH-severity credential-access findings.Impact
Ordinary OAuth terminology in documentation no longer produces PE3 findings. Actionable credential access remains detected, including attacks placed in documentation or adjacent to otherwise benign OAuth prose.
Validation
uv run pytest -q tests/unit/test_patterns.py tests/nodes/analyzers/test_binary_and_pe3_filtering.py tests/nodes/analyzers/test_static_runner_filtering.py— 204 passeduv run pytest -q --ignore=tests/unit/test_input_handler.py --ignore=tests/unit/test_input_handler_ssrf.py— 2,158 passed, 13 skipped, 4 xfaileduv run ruff check src/ tests/uv run ruff format --check src/ tests/The unfiltered test run completed with 2,199 passes and seven environment-specific failures in the two DNS/SSRF input-handler test files because public GitHub/GitLab hosts resolve to internal addresses on this network; the changed PE3 code is not involved.