fix(tui): resolve community image names in sandbox creation#798
Merged
johntmyers merged 1 commit intomainfrom Apr 9, 2026
Merged
fix(tui): resolve community image names in sandbox creation#798johntmyers merged 1 commit intomainfrom
johntmyers merged 1 commit intomainfrom
Conversation
Extract shared resolve_community_image() into openshell-core so both CLI and TUI expand bare sandbox names (e.g. "base") to full registry references. Previously the TUI passed the bare name directly, causing ImagePullBackOff in Kubernetes. Closes #786
pimlock
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TUI sandbox creation now resolves bare community image names (e.g.
"base") into fully-qualified registry references, matching CLI behavior. Previously the TUI passed bare names directly to the server, causingImagePullBackOffin Kubernetes.Related Issue
Closes #786
Changes
openshell_core::imagemodule with sharedresolve_community_image()function andDEFAULT_COMMUNITY_REGISTRYconstantresolve_from()to delegate image-name resolution to the shared function (Dockerfile detection stays CLI-only)resolve_community_image()call in TUI'sspawn_create_sandboxbefore buildingSandboxTemplateTesting
cargo checkpasses for openshell-core, openshell-cli, openshell-tuicargo test -p openshell-core -- image::)Checklist