Skip to content

fix(dco): Fix mismatched wording that breaks initial DCO checks #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewgrossman merged 1 commit into from
Jul 21, 2026
+5 −2
Merged

fix(dco): Fix mismatched wording that breaks initial DCO checks #2399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/dco.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
pull_request_target:
types: [opened, closed, synchronize]

env:
DCO_SIGN_COMMENT: "I have read the DCO document and I hereby sign the DCO."

permissions:
actions: write
checks: none
Expand All @@ -29,7 +32,7 @@ jobs:
- name: "DCO Assistant"
if: |
(github.event.comment.body == 'recheck' ||
github.event.comment.body == 'I have read the Contributor Agreement including DCO and I hereby sign the Contributor Agreement and DCO') ||
github.event.comment.body == env.DCO_SIGN_COMMENT) ||
github.event_name == 'pull_request_target'
uses: contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08
env:
Expand All @@ -46,6 +49,6 @@ jobs:
[Developer Certificate of Origin](https://github.com/NVIDIA/OpenShell/blob/main/DCO)
before we can accept your contribution. You can sign the DCO by
adding a comment below using this text:
custom-pr-sign-comment: "I have read the DCO document and I hereby sign the DCO."
custom-pr-sign-comment: ${{ env.DCO_SIGN_COMMENT }}
lock-pullrequest-aftermerge: false
use-dco-flag: true
Loading