Repository navigation
Stabilize Italian time readings and electronic punctuation tests - #533
Open
janbernloehr wants to merge 2 commits into
Open
janbernloehr wants to merge 2 commits into
janbernloehr wants to merge 2 commits into
Conversation
Signed-off-by: Jan Bernloehr <jbernloehr@nvidia.com>
11 of 14 tasks
Prefer numeric minutes for deterministic quarter-hour and half-hour readings, including times with seconds. Preserve equally weighted colloquial alternatives in nondeterministic grammars and pin the shared fixture preferences with path-cost and deployment regressions. Signed-off-by: Jan Bernloehr <jbernloehr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Stabilize Italian time readings across Pynini versions and correct the punctuation mode used by electronic normalization tests.
For
12:30, equal-cost verbalizer paths let Pynini 2.1.7 exports producedodici e mezzawhere the deterministic deployment fixture expectsdodici e trenta minuti. Give numeric minutes priority overmezzaandun quartofor:30and:15, with or without seconds. Nondeterministic verbalization retains both readings at equal cost. Strengthen Python checks to require the existing first expected reading, assert the cost ordering, and add shared Python/Sparrowhawk cases for12:15and15:30:30.The electronic fixture is shared with Sparrowhawk and expects raw grammar output, including a space before a final period (
punto com .). The Python test enabledpunct_post_process, which removes that space (punto com.), causing four failures. Run the shared fixture without punctuation cleanup and add eight separate cleanup cases. Existing electronic expectations and all existing time alternatives are preserved.Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here. (Not applicable: bugfix; regression coverage is included in both.)__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files? (Not applicable: no new folders.)Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files? (Not applicable: no new Python files.)Copyright 2015 and onwards Google, Inc.. See an example here. (Not applicable.)try import: ... except: ...) if not already done. (Not applicable: no import guards added or modified.)Validation:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.