Conversation
indexed_map_to_output stopped the left walk at index 1, so a leading epsilon that writes the first output character was left out of the span. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexed_map_to_output walks left through epsilon cells that insert output, but the bound is
aligned_start - 1 > 0, so cell 0 is never included.A leading
<eps>that writest, followed by input2writingw, is the spoken stringtw. The span of that one input character came back as(1, 2), so the caller keeps onlyw.The bound is now
>= 0. A span that starts after a real input character still stops on that character, so the leading insertion is not pulled into a later word.No existing issue.