Merge main into staging/hi_itn_v3 to resolve conflicts for #498 - #503
Closed
mayuris-00 wants to merge 3 commits into
Closed
mayuris-00 wants to merge 3 commits into
mayuris-00 wants to merge 3 commits into
Conversation
Signed-off-by: Mayuri S <mayuris@nvidia.com> # Conflicts: # Jenkinsfile # tests/nemo_text_processing/hi/test_roman.py # tests/nemo_text_processing/hi/test_serial.py
Signed-off-by: Mayuri S <mayuris@nvidia.com>
folivoramanh
requested review from
folivoramanh
and removed request for
folivoramanh
September 29, 2026 09:25
Signed-off-by: Mayuri S <mayuris@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Brings current main into staging/hi_itn_v3 so #498 becomes mergeable.
Conflicts resolved:
Full hi test suite passes locally (1271 tests); pre-commit clean.
Please merge with "Create a merge commit" (not squash), same as #348, so main is carried into staging's history.
DCO flags 3 commits already on main (acacc21, 1f12635, c8ad73e); my merge commit is signed off correctly.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.