Skip to content

Merge main into staging/hi_itn_v3 to resolve conflicts for #498 - #503

Closed
mayuris-00 wants to merge 3 commits into
NVIDIA:staging/hi_itn_v3from
mayuris-00:hi-itn-v3-resolve-conflicts
Closed

mayuris-00 wants to merge 3 commits into
NVIDIA:staging/hi_itn_v3from
mayuris-00:hi-itn-v3-resolve-conflicts

Conversation

@mayuris-00

Copy link
Copy Markdown

What does this PR do ?

Brings current main into staging/hi_itn_v3 so #498 becomes mergeable.

Conflicts resolved:

  • Jenkinsfile: JA/KO caches from main; HI_TN_CACHE kept at 09-21-26-0
  • hi test_roman.py / test_serial.py: main's TN tests unchanged, ITN test_denorm added

Full hi test suite passes locally (1271 tests); pre-commit clean.

Please merge with "Create a merge commit" (not squash), same as #348, so main is carried into staging's history.
DCO flags 3 commits already on main (acacc21, 1f12635, c8ad73e); my merge commit is signed off correctly.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

Signed-off-by: Mayuri S <mayuris@nvidia.com>

# Conflicts:
#	Jenkinsfile
#	tests/nemo_text_processing/hi/test_roman.py
#	tests/nemo_text_processing/hi/test_serial.py
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@folivoramanh
folivoramanh requested review from folivoramanh and removed request for folivoramanh September 29, 2026 09:25
Signed-off-by: Mayuri S <mayuris@nvidia.com>
@mayuris-00 mayuris-00 closed this Sep 30, 2026
@mayuris-00
mayuris-00 deleted the hi-itn-v3-resolve-conflicts branch September 30, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant