Skip to content

feat(python): add nemo-relay-plugin worker SDK package#310

Draft
willkill07 wants to merge 2 commits into
NVIDIA:mainfrom
willkill07:wkk_dynamic-plugin-6-python-sdk
Draft

feat(python): add nemo-relay-plugin worker SDK package#310
willkill07 wants to merge 2 commits into
NVIDIA:mainfrom
willkill07:wkk_dynamic-plugin-6-python-sdk

Conversation

@willkill07

Copy link
Copy Markdown
Member

Overview

Add the pure-Python nemo-relay-plugin worker SDK package and its packaging/test support.

Stack dependency: this PR cannot be merged until parent stacked PR #309 is merged: #309

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Add python/plugin with high-level worker plugin APIs, generated gRPC stubs, runtime helpers, continuations, and streaming helpers.
  • Add Python SDK tests and a Python gRPC worker example.
  • Update Python test, coverage, packaging, CI wheel upload, attribution, and pre-commit configuration for the new package.

Validation run across the completed stack:

  • cargo test -p nemo-relay-types
  • cargo test -p nemo-relay-plugin
  • cargo test -p nemo-relay-worker-proto
  • cargo test -p nemo-relay-worker
  • cargo check -p nemo-relay-cli

Where should the reviewer start?

Start with python/plugin/src/nemo_relay_plugin/_api.py, then review python/tests/plugin/test_worker_sdk.py.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 882119b3-e7b4-417c-8fc4-8052a4ac77dc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XXL PR is very large label Jun 25, 2026
@github-actions github-actions Bot added Feature a new feature lang:python PR changes/introduces Python code lang:rust PR changes/introduces Rust code labels Jun 25, 2026
@github-actions

Copy link
Copy Markdown

@willkill07 willkill07 self-assigned this Jun 25, 2026
@willkill07 willkill07 added this to the 0.5 milestone Jun 25, 2026
@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from acf1481 to 3b75e88 Compare June 25, 2026 18:16
@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 3b75e88 to d372191 Compare June 25, 2026 18:44
@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from d372191 to efe47a2 Compare June 25, 2026 19:03
@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from efe47a2 to 67e1ab3 Compare June 25, 2026 23:21
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 67e1ab3 to e57177e Compare June 25, 2026 23:40
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from e57177e to ca5feb0 Compare June 26, 2026 00:19
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from ca5feb0 to 2e82788 Compare June 26, 2026 00:45
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 2e82788 to a29a7bd Compare June 26, 2026 02:28
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 3f74972 to d306893 Compare June 26, 2026 22:14
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from d306893 to 84df93d Compare June 26, 2026 22:27
@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 84df93d to 5a34e6a Compare June 26, 2026 22:37
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 5a34e6a to ac42b72 Compare June 26, 2026 22:47
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from ac42b72 to 2331407 Compare June 26, 2026 23:03
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 2331407 to 41e15f3 Compare June 26, 2026 23:20
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

@willkill07 willkill07 force-pushed the wkk_dynamic-plugin-6-python-sdk branch from 41e15f3 to da40ad5 Compare June 26, 2026 23:35
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Signed-off-by: Will Killian <wkillian@nvidia.com>
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

6 similar comments
@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

Signed-off-by: Will Killian <wkillian@nvidia.com>
@github-actions

Copy link
Copy Markdown

License Diff

Compared against origin/main.

Lockfile license changes

Lockfile License Changes

Rust

Added

  • None

Removed

  • None

Updated/Changed

  • None

Node

Added

  • None

Removed

  • None

Updated/Changed

  • None

Python

Added

  • grpcio 1.81.1 (Apache-2.0)

Removed

  • None

Updated/Changed

protobuf

Before:

  • protobuf 7.35.1 (BSD-3-Clause)

After:

  • protobuf 6.33.6 (BSD-3-Clause)
Status output
[license-diff] selected languages: rust, node, python
[license-diff] generating current inventory
[license-diff] current: generating Rust inventory
[license-diff] current: Rust inventory complete (363 packages)
[license-diff] current: generating Node inventory
[license-diff] current: Node inventory complete (364 packages)
[license-diff] current: generating Python inventory
[license-diff] current: Python inventory complete (105 packages)
[license-diff] current inventory complete
[license-diff] checking out base ref origin/main into a temporary worktree
[license-diff] base: generating Rust inventory
[license-diff] base: Rust inventory complete (363 packages)
[license-diff] base: generating Node inventory
[license-diff] base: Node inventory complete (364 packages)
[license-diff] base: generating Python inventory
[license-diff] base: Python inventory complete (104 packages)
[license-diff] base inventory complete
[license-diff] removing temporary base worktree
[license-diff] comparing inventories
[license-diff] rendering Markdown output
[license-diff] done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature a new feature lang:python PR changes/introduces Python code lang:rust PR changes/introduces Rust code size:XXL PR is very large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant