Draft: merge any model calc one block scores#994
Open
danielkorzekwa wants to merge 2 commits intodkorzekwa/anymodel_build_library_and_statsfrom
Open
Draft: merge any model calc one block scores#994danielkorzekwa wants to merge 2 commits intodkorzekwa/anymodel_build_library_and_statsfrom
danielkorzekwa wants to merge 2 commits intodkorzekwa/anymodel_build_library_and_statsfrom
Conversation
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
danielkorzekwa
changed the title
| - ``replacement_library_path`` (Path): Path to the replacement library JSON file. | ||
| - ``solutions_path`` (Path): Path to puzzle solutions JSON file or directory containing solution files. | ||
| - ``solutions_to_validate`` (list[int], optional): Indices of specific solutions to validate. | ||
| Validates all solutions if None. |
Collaborator
There was a problem hiding this comment.
Fyi, I think this reverts previously fixed docstrings. If you see doc building failures - this might be it
kevalmorabia97
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merging dkorzekwa/any_model_calc_one_block_scores into dkorzekwa/anymodel_build_library_and_stats - this MR is only for reviewing. Ultimately dkorzekwa/any_model_calc_one_block_scores should be merged into feature/puzzletron once dkorzekwa/anymodel_build_library_and_stats is merged there.