Draft: Merge anymodel pruning#990
Open
danielkorzekwa wants to merge 2 commits intodkorzekwa/anymodel_activation_scoringfrom
Open
Draft: Merge anymodel pruning#990danielkorzekwa wants to merge 2 commits intodkorzekwa/anymodel_activation_scoringfrom
danielkorzekwa wants to merge 2 commits intodkorzekwa/anymodel_activation_scoringfrom
Conversation
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
kevalmorabia97
approved these changes
Mar 6, 2026
| pruning_mixin, | ||
| parent_checkpoint_dir: str, | ||
| model_config_overrides_json: str, | ||
| model_config_overrides_dict: dict, |
Collaborator
There was a problem hiding this comment.
Suggested change
| model_config_overrides_dict: dict, | |
| model_config_overrides_dict: dict | str, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merging dkorzekwa/anymodel_pruning into dkorzekwa/anymodel_acivation scoring - this MR is only for reviewing. Ultimately dkorzekwa/anymodel_pruning should be merged into feature/puzzletron once dkorzekwa/anymodel_acivation scoring is merged there.