Skip to content

Remove unused diffusers/cache_diffusion/pipeline and cuda-python dependency#984

Merged
kevalmorabia97 merged 3 commits intorelease/0.42.0from
jingyux/cuda-python-remove
Mar 6, 2026
Merged

Remove unused diffusers/cache_diffusion/pipeline and cuda-python dependency#984
kevalmorabia97 merged 3 commits intorelease/0.42.0from
jingyux/cuda-python-remove

Conversation

@jingyu-ml
Copy link
Contributor

@jingyu-ml jingyu-ml commented Mar 5, 2026

cuda-python has mixed license and needs EStaff approval for usage. And till 0.42, it was only used in examples/diffusers/cache_diffusion/pipeline which has not been updated in 9 months and not used anymore hence removing

Signed-off-by: Jingyu Xin <jingyux@nvidia.com>
@jingyu-ml jingyu-ml requested a review from a team as a code owner March 5, 2026 19:35
@jingyu-ml jingyu-ml requested review from kaix-nv and removed request for a team March 5, 2026 19:35
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 134f96df-733c-4ca1-860f-b89ed1ff728a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
📝 Walkthrough

Walkthrough

Removed a version constraint on cuda-python<13 from the diffusers example requirements file. Other dependencies remain unchanged.

Changes

Cohort / File(s) Summary
Dependency constraint update
examples/diffusers/requirements.txt
Removed cuda-python<13 version constraint; other dependencies (nvtx, opencv-python, sentencepiece) remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions removing 'cuda-python dependency' which aligns with the actual change (removing cuda-python<13), but also references 'diffusers/cache_diffusion/pipeline' which is not present in the changeset. Update the title to accurately reflect only the actual changes made, such as 'Remove cuda-python dependency from diffusers requirements' to avoid misleading reviewers about the scope of changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jingyux/cuda-python-remove

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.73%. Comparing base (eaf5d7e) to head (021564e).
⚠️ Report is 1 commits behind head on release/0.42.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/0.42.0     #984   +/-   ##
===============================================
  Coverage           73.73%   73.73%           
===============================================
  Files                 196      196           
  Lines               20482    20482           
===============================================
  Hits                15102    15102           
  Misses               5380     5380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97 kevalmorabia97 changed the title Remove Cuda python Remove unused diffusers/cache_diffusion/pipeline and cuda-python dependency Mar 6, 2026
@kevalmorabia97 kevalmorabia97 requested review from kevalmorabia97 and removed request for kaix-nv March 6, 2026 16:23
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97 kevalmorabia97 merged commit e2a4a8b into release/0.42.0 Mar 6, 2026
37 checks passed
@kevalmorabia97 kevalmorabia97 deleted the jingyux/cuda-python-remove branch March 6, 2026 18:22
kevalmorabia97 added a commit that referenced this pull request Mar 6, 2026
…ndency (#996)

`cuda-python` has mixed license and needs EStaff approval for usage. And
till 0.42, it was only used in
`examples/diffusers/cache_diffusion/pipeline` which has not been updated
in 9 months and not used anymore hence removing.

Also cherry-picked to `release/0.42.0` branch:
#984

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* Removed TensorRT/ONNX deployment and inference tooling, related model
export/configuration, and runtime helpers from the cache-optimized
diffusion examples; removed the cuda-python example dependency.
* **Tests**
* Removed the example benchmarking script and its associated benchmark
test.
* **Documentation**
* Strengthened dependency-review, security, and PR guidance; updated PR
template and contributing documentation.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants