Skip to content

fix: https://github.com/NVIDIA/Model-Optimizer/issues/981 #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChenhanYu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: https://github.com/NVIDIA/Model-Optimizer/issues/981 #983

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ab53db
fix: https://github.com/NVIDIA/Model-Optimizer/issues/981
ChenhanYu Mar 5, 2026
014c1a0
Update modelopt/torch/opt/plugins/mcore_dist_checkpointing.py
kevalmorabia97 Mar 5, 2026
6e567e6
chg: taking feedback to omit the field
ChenhanYu Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modelopt/torch/opt/plugins/mcore_dist_checkpointing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,12 @@ def _parse_transformer_config(transformer_config: dict) -> dict:
if isinstance(v, (bool, int, str)):
config[k] = v
else:
config[k] = str(v)
# Handle https://github.com/NVIDIA/Model-Optimizer/issues/981 where
# hierarchical_context_parallel_sizes: [8, 2] will raise a TypeError.
try:
config[k] = str(v)
except (AttributeError, TypeError):
print("Warning: TransformerConfig.{} does not have _repr_ implemented.")
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add something to the empty {}?


return config

Expand Down
Loading