Skip to content

Conversation

@danielkorzekwa
Copy link

What does this PR do?

Two bug fixes:

  1. Saving mip checkpoint (correctly saving model code files)
  2. Passing dtype as object instead of string to calculate_losses_pipeline and load_and_shard_model

@danielkorzekwa danielkorzekwa requested a review from a team as a code owner December 22, 2025 12:04
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 22, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (1d8bd20) to head (c162da2).
⚠️ Report is 3 commits behind head on feature/compress.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/compress     #718      +/-   ##
====================================================
- Coverage             74.47%   74.38%   -0.09%     
====================================================
  Files                   183      185       +2     
  Lines                 18416    18521     +105     
====================================================
+ Hits                  13715    13777      +62     
- Misses                 4701     4744      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LianaMikael LianaMikael self-requested a review December 22, 2025 12:16
…files) 2) passing dtype as object instead of string to calculate_losses_pipeline and load_and_shard_model

Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
@danielkorzekwa danielkorzekwa force-pushed the dkorzekwa/dtype_and_mipcheckpointing_fixes branch from 3bc3e0a to c162da2 Compare December 22, 2025 15:17
@danielkorzekwa danielkorzekwa merged commit 2e813bf into feature/compress Dec 22, 2025
22 checks passed
@danielkorzekwa danielkorzekwa deleted the dkorzekwa/dtype_and_mipcheckpointing_fixes branch December 22, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants