Use kitchen FA in huggingface plugin #674
Open
+193
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 74.65% 74.65% -0.01%
==========================================
Files 192 192
Lines 18909 18918 +9
==========================================
+ Hits 14117 14123 +6
- Misses 4792 4795 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shiyang Chen <shiychen@nvidia.com>
Signed-off-by: Shiyang Chen <shiychen@nvidia.com>
realAsma
reviewed
Dec 24, 2025
Comment on lines
+428
to
+448
| @property | ||
| def is_mxfp4(self): | ||
| """Check if is MXFP4.""" | ||
| return ( | ||
| self.is_mx_format and self.num_bits == (2, 1) and self.block_sizes.get(-1, None) == 32 | ||
| ) | ||
|
|
||
| @property | ||
| def is_mxfp6(self): | ||
| """Check if is MXFP6.""" | ||
| return ( | ||
| self.is_mx_format and self.num_bits == (3, 2) and self.block_sizes.get(-1, None) == 32 | ||
| ) | ||
|
|
||
| @property | ||
| def is_mxfp8(self): | ||
| """Check if is MXFP8.""" | ||
| return ( | ||
| self.is_mx_format and self.num_bits == (4, 3) and self.block_sizes.get(-1, None) == 32 | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
can you add arguments to is_mx_format method instead of elaborating like this? We would need to make is_max_format a regular method instead of a property - but that should be okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? new feature
Overview: use kitchen FA in huggingface plugin
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information