-
Notifications
You must be signed in to change notification settings - Fork 222
Use gesvd as solver #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use gesvd as solver #661
Conversation
Signed-off-by: scavallari <scavallari@nviia.com>
95f9b7e to
c513c47
Compare
|
LGTM. As a reference, could you point me to the documentation? |
|
/ok to test c513c47 |
|
@andompesta seems like our SVD Quant tests fail on CPU: https://github.com/NVIDIA/Model-Optimizer/actions/runs/20025754823/job/58410748645?pr=661 FAILED tests/unit/torch/quantization/test_calib.py::test_svdquant_lora_weights
FAILED tests/unit/torch/quantization/test_quantize_cpu.py::test_quantize[config4-SimpleLinear]
FAILED tests/unit/torch/quantization/test_quantize_cpu.py::test_quantize[config4-SimpleConvLinear]
FAILED tests/unit/torch/quantization/test_quantize_cpu.py::test_save_restore[SimpleLinear-quant_config3]RuntimeError: torch.linalg.svd: keyword argument `driver=` is only supported on CUDA inputs with cuSOLVER backend. |
|
I see, I gived it for granted that svd runs on cuda devices |
|
Thanks. One more thing:
Please use |
79b14a2 to
389728b
Compare
389728b to
9fbbbeb
Compare
|
Still failing |
What does this PR do?
Type of change: ?
Bug fix: default svd solver does not work for ill-conditioned matrixes. Switch to
gesvdsolver as it is more accurate (as per documentation) as does not fails for ill-conditioned matrixesOverview: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information