Skip to content

fix: CodeRabbit auto-fixes for PR #1330 #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grzegorz-k-karch merged 1 commit into from
Apr 23, 2026
Merged

fix: CodeRabbit auto-fixes for PR #1330 #1339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions modelopt/torch/puzzletron/tools/checkpoint_utils_hf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,18 @@ def save_checkpoint_from_shards(
local_sd = {k: v.cpu() for k, v in model.state_dict().items()}
if dist_utils.size() > 1:
if dist_utils.is_master():
gathered: list[dict] = [{}] * dist_utils.size()
gathered: list[dict] = [None] * dist_utils.size()
tdist.gather_object(local_sd, gathered, dst=0)
full_sd: dict[str, torch.Tensor] = {}
for shard_sd in gathered:
if shard_sd is None:
continue
full_sd.update(shard_sd)
_save_checkpoint(model.config, full_sd, checkpoint_dir, descriptor)
else:
tdist.gather_object(local_sd, dst=0)
# Barrier ensures all ranks wait until file I/O completes before continuing
dist_utils.barrier()
else:
_save_checkpoint(model.config, local_sd, checkpoint_dir, descriptor)

Expand Down Expand Up @@ -484,4 +488,4 @@ def save_model_config(model_config: PretrainedConfig, checkpoint_dir: Path | str
dataclasses.asdict(conf) if dataclasses.is_dataclass(conf) else conf
for conf in model_config.block_configs
]
model_config.save_pretrained(checkpoint_dir)
model_config.save_pretrained(checkpoint_dir)