Skip to content

Conversation

@Phlip79
Copy link
Member

@Phlip79 Phlip79 commented Dec 24, 2025

What does this PR do ?

Oncall should not add bot. It should also not have repeated members.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Phlip79 Phlip79 marked this pull request as ready for review December 24, 2025 18:24
@Phlip79 Phlip79 requested a review from a team as a code owner December 24, 2025 18:24
@Phlip79 Phlip79 requested a review from chtruong814 December 24, 2025 18:24
@Phlip79 Phlip79 enabled auto-merge December 24, 2025 18:24
@Phlip79 Phlip79 changed the title Cleanup oncall Ignore bot for oncall Dec 30, 2025
@Phlip79
Copy link
Member Author

Phlip79 commented Dec 31, 2025

/ok to test 111416f

@Phlip79
Copy link
Member Author

Phlip79 commented Dec 31, 2025

/ok to test 4c53c10

@Phlip79 Phlip79 added this pull request to the merge queue Dec 31, 2025
Merged via the queue into NVIDIA:main with commit 52bf635 Dec 31, 2025
47 checks passed
@Phlip79 Phlip79 deleted the philip/cleanup-oncall branch December 31, 2025 19:46
@Phlip79 Phlip79 linked an issue Dec 31, 2025 that may be closed by this pull request
7 tasks
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jan 9, 2026
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overhaul oncall

3 participants