Skip to content

Conversation

@terrykong
Copy link
Contributor

@terrykong terrykong commented Jan 23, 2024

This PR should not be merged if the t5x/pax tests fail and may require us unpinning or bumping the core libraries or downgrading pax/t5x.

To review:

@terrykong terrykong marked this pull request as ready for review January 23, 2024 17:28
@terrykong terrykong marked this pull request as draft January 23, 2024 17:28
@terrykong
Copy link
Contributor Author

@DwarKapex So flax==0.7.5 is not new enough for the patches in version control from when we cut this release branch. I'm going to revert it to see if that resolves the build issues for rosetta

@terrykong
Copy link
Contributor Author

Looks like JAX ARM builds aren't succeeding, possibly due to the patch @DwarKapex . Can you look into this and decide how you'd like to proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants