Add data-loading bottleneck diagnostic skill - #6466
Open
rostan-t wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
Contributor
|
| Filename | Overview |
|---|---|
| skills/data-loading-bottleneck/SKILL.md | Defines the end-to-end bounded detection, replay, profiling, and reporting workflow. |
| skills/data-loading-bottleneck/references/profiling.md | Documents profile instrumentation, structural validation, overhead checks, and evidence-based localization. |
| skills/data-loading-bottleneck/references/pytorch-dali.md | Specifies construction and equivalence requirements for paired Real and Replay loaders. |
| skills/data-loading-bottleneck/scripts/collect_preflight.py | Collects workload, environment, GPU, source, storage, and optional-tool readiness information. |
| skills/data-loading-bottleneck/scripts/summarize_nsys.py | Exports and summarizes bounded NVTX and CUDA activity from Nsight Systems reports. |
| skills/data-loading-bottleneck/assets/report-template.md | Provides the required structure for workload, detection, localization, recommendation, and confidence reporting. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Preflight workload and environment] --> B{Canonical run available?}
B -- No --> Z[Report INCONCLUSIVE]
B -- Yes --> C[Run bounded Real workload]
C --> D{LoaderEvaluator available?}
D -- Yes --> E[Run equivalent Replay workload]
E --> F{Replay speedup}
F -- <= 1.10x --> G[Report NOT DETECTED]
F -- > 1.10x --> H[Profile and localize]
D -- No --> H
H --> I{Validated input-path delay?}
I -- Yes --> J[Report DETECTED or POTENTIAL with cause]
I -- No --> Z
Reviews (2): Last reviewed commit: "Add data-loading bottleneck diagnostic s..." | Re-trigger Greptile
Contributor
|
/nvskills-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Create a skill allowing agent to detect and localize data loading bottlenecks in PyTorch training.
The workflow roughly contains two important phases:
LoaderEvaluatorThe complete workflow is more complex and looks as follows:
LoaderEvaluatoris or can be made importable , continue to 3. Else, go to 4.LoaderEvaluator's replay mode. Establish if there's a measured bottleneck. If we this steps provdes that there's no bottleneck, go to 5. Otherwise, continue to 4. to localize.This was tested on multiple models, with different environment requirements, including simple ResNet50, OpenCLIP, LeWorldModel, and Hugging Face timm.
In terms of the model used by the agent, I found that GPT 5.6 Terra or equivalent is a sound minimum requirement to run this reliably, although it can sometimes fail to accurately follow all instructions, like the shape of the report.
I unfortunately couldn't commit evaluations as the skill CI doesn't support GPU environments.
Additional information:
Affected modules and functionalities:
Skill created.
Key points relevant for the review:
Note that if you run locally, depending on the workload, it may take time to complete.
Tests:
Skill CI doesn't support GPU workers yet
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4796