Skip to content

Skip Paddle iterator tests with ASan - #6465

Open
JanuszL wants to merge 1 commit into
NVIDIA:mainfrom
JanuszL:skip-paddle-asan-iterators
Open

Skip Paddle iterator tests with ASan#6465
JanuszL wants to merge 1 commit into
NVIDIA:mainfrom
JanuszL:skip-paddle-asan-iterators

Conversation

@JanuszL

@JanuszL JanuszL commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Category:

Other (Tests, Configuration)

Description:

Skips the Paddle iterator QA suite when AddressSanitizer is enabled. Paddle 3.4's
external libpir library reports an alloc/dealloc mismatch during Python shutdown,
after the DALI iterator tests have completed successfully. Regular CI continues to
run the full Paddle iterator coverage.

Additional information:

Affected modules and functionalities:

  • qa/TL0_FW_iterators/test_paddlepaddle.sh: Paddle iterator QA execution in
    sanitizer jobs.

Key points relevant for the review:

  • The workaround is scoped to Paddle sanitizer runs; it does not disable ASan
    mismatch detection globally or suppress DALI errors.
  • Remove the exclusion after a CUDA 13 Paddle wheel fixes the libpir teardown
    mismatch.

Tests:

  • Existing tests apply
    • qa/TL0_FW_iterators/test_paddlepaddle.sh runs the existing Paddle iterator
      suite in non-sanitizer jobs.
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR skips the full Paddle iterator QA suite when AddressSanitizer is enabled, avoiding a known external libpir teardown mismatch while preserving regular CI coverage.

  • Moves test_fw_iterators into the existing sanitizer guard.
  • Documents the Paddle 3.4 teardown issue and the temporary nature of the skip.

Confidence Score: 5/5

The PR appears safe to merge because the Paddle coverage reduction is limited to the ASan configuration affected by the acknowledged external teardown failure.

The QA harness treats a nonempty sanitizer flag as enabling ASan, so moving the final Paddle iterator invocation under the existing guard consistently skips the affected suite without changing regular CI execution.

Important Files Changed

Filename Overview
qa/TL0_FW_iterators/test_paddlepaddle.sh Correctly scopes all Paddle iterator invocations out of ASan runs while retaining them in regular CI.

Reviews (1): Last reviewed commit: "Skip Paddle iterator tests with ASan" | Re-trigger Greptile

@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [65031706]: BUILD STARTED

@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [65031706]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants