Skip to content

fix(observability): classify spans for Intake - #232

Merged
ayushag-nv merged 1 commit into
mainfrom
fix/intake-openinference-span-kind
Jul 31, 2026
Merged

fix(observability): classify spans for Intake#232
ayushag-nv merged 1 commit into
mainfrom
fix/intake-openinference-span-kind

Conversation

@nachiketb-nvidia

@nachiketb-nvidia nachiketb-nvidia commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What

Add OpenInference span kinds to Switchyard OTEL spans.

Why

Intake derives its displayed kind from openinference.span.kind, so spans carrying only GenAI attributes render as UNKNOWN.

How

  • classify request and orchestration spans as CHAIN
  • classify the GenAI client-call span as LLM
  • match the convention emitted by NeMo Relay

What to review

Confirm the five existing span sites use the intended OpenInference classification.

Validation

No tests run, per request.

Summary by CodeRabbit

  • Observability
    • Added OpenInference span-kind metadata to application runs, server requests, algorithm operations, and LLM calls.
    • Improved tracing consistency for request attempts and chained operations.

Signed-off-by: nachiketb <nachiketb@nvidia.com>
@nachiketb-nvidia
nachiketb-nvidia requested a review from a team as a code owner July 31, 2026 19:04
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 39fca32c-dc58-4021-af61-ff63b450e99f

📥 Commits

Reviewing files that changed from the base of the PR and between 02d3f23 and 61934d6.

📒 Files selected for processing (4)
  • crates/libsy-llm-client/src/client.rs
  • crates/libsy/src/core/algorithm.rs
  • crates/libsy/src/observability.rs
  • crates/switchyard-server/src/observability.rs

Walkthrough

Changes

OpenInference span classification

Layer / File(s) Summary
Request and run span classification
crates/switchyard-server/src/observability.rs, crates/libsy/src/observability.rs
Server request and libsy.run spans now record openinference.span.kind as CHAIN.
Algorithm and upstream span classification
crates/libsy/src/core/algorithm.rs, crates/libsy-llm-client/src/client.rs
Algorithm LLM spans record CHAIN, client call spans record LLM, and upstream attempt spans record CHAIN.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A rabbit hops through spans so neat,
With CHAIN tags on every beat.
LLM marks the client call,
Clear signals travel through them all.
Tracing blooms from ear to ear.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the span classification changes for Intake.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@ayushag-nv
ayushag-nv merged commit c536c0a into main Jul 31, 2026
18 checks passed
@ayushag-nv
ayushag-nv deleted the fix/intake-openinference-span-kind branch July 31, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants