-
Notifications
You must be signed in to change notification settings - Fork 586
docs(run-rails): updates for clarity and correctness #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview |
Greptile SummaryThis PR improves the clarity and correctness of the run-rails documentation through several targeted enhancements. The changes focus on removing outdated information (deprecated Key improvements:
|
| Filename | Overview |
|---|---|
| docs/run-rails/core-classes.md | Added context variable usage documentation and corrected example variable name from "score" to "user_message"; removed deprecated streaming parameter from table |
| docs/run-rails/generation-options.md | Reordered sections to prioritize "Disabling Rails" over "Output Variables" for better user flow and logical organization |
| docs/run-rails/index.md | Simplified description for stream_async() by removing "for responsive UIs" for more general applicability |
| docs/run-rails/streaming.md | Added deprecation warning for StreamingHandler, emphasized output rails with bold formatting, and removed outdated version requirements section |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Docs as Documentation
participant User as End User
Dev->>Docs: Remove deprecated `streaming` parameter from table
Dev->>Docs: Add context variable usage examples
Dev->>Docs: Correct example variable name (score → user_message)
Dev->>Docs: Reorder sections (Disabling Rails before Output Variables)
Dev->>Docs: Add StreamingHandler deprecation warning
Dev->>Docs: Remove outdated version requirements
Dev->>Docs: Emphasize output rails with bold formatting
Dev->>Docs: Simplify stream_async() description
User->>Docs: Read updated documentation
Docs-->>User: Clearer, more accurate information
Docs-->>User: Better logical flow
Docs-->>User: Current best practices
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
miyoungc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Please accept the suggestions if they look good @Pouyanpi .
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
|
Applied my suggestions to merge the PR. If any of my suggestions need changes, let's cut another PR. Wanted to merge this cause I'm gonna run another iteration on this section as well. thank you! |
No description provided.