fix(ci): match Nemotron remote reloads with legacy PEFT exports - #3952
Merged
Merged
Conversation
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
yuhezhang-ai
force-pushed
the
yuhez/fix/amint-356-hf-peft-reload
branch
from
September 21, 2026 01:11
334a8c7 to
7156f57
Compare
yuhezhang-ai
changed the base branch from
main
to
yuhez/investigate/gptoss-length-parity
September 21, 2026 01:11
Signed-off-by: Yuhe Zhang <yuhez@nvidia.com>
Base automatically changed from
yuhez/investigate/gptoss-length-parity
to
main
September 21, 2026 17:58
Contributor
Author
|
/ok to test dd2b963 |
yuhezhang-ai
marked this pull request as ready for review
September 21, 2026 19:39
akoumpa
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Nemotron PEFT checkpoints should work with either HF's newer built-in model or the legacy remote-code model, using the matching export format:
checkpoint.v4_compatible: truewithtrust_remote_code: true.We are using the legacy path in CI for now because we found a bug in HF's built-in Nemotron Mamba implementation that causes numerical mismatches. We submitted the fix upstream as huggingface/transformers#48989. The current CI results validate the legacy path; they do not establish a full built-in-model CI pass.
This PR switches four checkpoint-robustness tests to the matching legacy export, keeping our existing HF dependency rather than pinning an unreleased patched build. The previous tests mixed the default export's
model.*adapter names with a remote-code model expecting legacybackbone.*names, causing missing-adapter failures.The export override lives under
ci.checkpoint_robustness, so it applies only to checkpoint tests. Normal recipe export settings remain unchanged.Stacked on #3953 for its fixed Mamba cumsum parity configuration. The diff against that base adds only the legacy-export override and explanatory comment to each recipe.
Changelog
Before your PR is "Ready for review"
446557db8d91b24dd920bb408fae6b68e19dce00.All four recipes pass all six phases: source reference, source parity, training/save, AutoModel reload, HF reload and resume. AutoModel reload outputs are bitwise identical in all four; HF reload verifies every saved adapter tensor exactly and passes the existing numerical thresholds.
Additional Information
Addresses the legacy-export/receiver mismatch in AMINT-356. The upstream HF fix includes regression tests and controlled numerical evidence. Once a suitable HF release includes the fix, the built-in path can be validated again for these CI tests.