Skip to content

fix(dflash): apply activation checkpointing to the draft - #3946

Open
kashif wants to merge 2 commits into
NVIDIA-NeMo:mainfrom
kashif:kashif/fix/dflash-activation-checkpointing
Open

kashif wants to merge 2 commits into
NVIDIA-NeMo:mainfrom
kashif:kashif/fix/dflash-activation-checkpointing

Conversation

@kashif

@kashif kashif commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

DFlash never wired up distributed.activation_checkpointing for the draft model, so the flag was silently ignored. DSpark already had this. Moved DSpark's helper into the shared _spec_train_utils and call it from DFlash too.

Changelog

  • Add apply_draft_activation_checkpointing to _spec_train_utils.py, shared by DSpark and DFlash.
  • Wire it into TrainDFlashRecipe.setup() before the draft's DDP wrap (covers DFlash2, Domino, and JetSpec via inheritance).
  • Move DSpark's activation checkpointing tests next to the shared helper in test_spec_train_utils.py.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

Additional Information

Signed-off-by: Kashif Rasul <kashif.rasul@gmail.com>
@kashif
kashif requested a review from a team as a code owner September 19, 2026 11:57
@copy-pr-bot

copy-pr-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread tests/unit_tests/recipes/llm/test_spec_train_utils.py Outdated
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-customer Waiting on the original author to respond label Sep 20, 2026
Signed-off-by: Kashif Rasul <kashif.rasul@gmail.com>
@HuiyingLi

Copy link
Copy Markdown
Contributor

/claude review

@claude

claude Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

LGTM

This branch was successfully deployed

3 active deployments
public 97a5e51f Deployed Sep 20, 2026 by copy-pr-bot[bot] via release / finalize / notify #4704
test 97a5e51f Deployed Sep 20, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #10874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants