Conversation
Signed-off-by: Kashif Rasul <kashif.rasul@gmail.com>
khazic
reviewed
Sep 20, 2026
Signed-off-by: Kashif Rasul <kashif.rasul@gmail.com>
Contributor
|
/claude review |
Contributor
|
LGTM |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
DFlash never wired up
distributed.activation_checkpointingfor the draft model, so the flag was silently ignored. DSpark already had this. Moved DSpark's helper into the shared_spec_train_utilsand call it from DFlash too.Changelog
apply_draft_activation_checkpointingto_spec_train_utils.py, shared by DSpark and DFlash.TrainDFlashRecipe.setup()before the draft's DDP wrap (covers DFlash2, Domino, and JetSpec via inheritance).test_spec_train_utils.py.Before your PR is "Ready for review"
Pre checks:
Additional Information