Skip to content

fix(ci): serialize convergence model config preparation - #3941

Merged
athitten merged 1 commit into
mainfrom
athitten/fix/gemma4-convergence-config-race
Sep 21, 2026
Merged

athitten merged 1 commit into
mainfrom
athitten/fix/gemma4-convergence-config-race

Conversation

@athitten

Copy link
Copy Markdown
Contributor

What does this PR do ?

Prepares the resolved convergence recipe and Hugging Face model config once on node 0 before distributed training starts.

Changelog

  • Resolve the shared finetune config only on node 0.
  • Warm and validate the Hugging Face model config before launching torchrun.
  • Make other nodes wait for a job-specific readiness marker with a timeout.
  • Fail before training when config resolution or model config preparation fails.

Before your PR is "Ready for review"

Pre checks:

  • Read and followed the contributor guidelines.
  • Ran 90 focused CI unit tests in the failing job's container.
  • Ran a CPU-only Gemma 4 cold-cache launcher preflight in the failing job's container.
  • Ran bash -n and git diff --check.
  • No documentation update is required for this internal CI launcher change.

Full convergence validation requires the original 4-node, 32-H100 topology.

Additional Information

Signed-off-by: Abhishree <athittenaman@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@athitten

Copy link
Copy Markdown
Contributor Author

/ok to test fe3c0b4

@athitten
athitten merged commit 637cc36 into main Sep 21, 2026
82 checks passed
@athitten
athitten deleted the athitten/fix/gemma4-convergence-config-race branch September 21, 2026 18:43

This branch was successfully deployed

3 active deployments
public fe3c0b47 Deployed Sep 18, 2026 by copy-pr-bot[bot] via release / finalize / notify #4698
test fe3c0b47 Deployed Sep 18, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #10866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants