Conversation
…ers pin The documented install command is rejected by uv: --all-extras and --extra <EXTRA> are mutually exclusive. vlm-media is a declared extra (pyproject.toml:179) and is already covered by --all-extras. The page cites the repository's pinned transformers==5.12.1; the pin moved to 5.15.1 in NVIDIA-NeMo#3781 and pyproject.toml:89 now reads 5.15.1.
waynel96
force-pushed
the
docs/glm-5-3-flash-install-and-pin
branch
from
September 18, 2026 21:13
b3c0360 to
07413f2
Compare
Contributor
|
/ok to test 47ace70 |
svcnvidia-nemo-ci
added
the
waiting-on-maintainers
jgerh
reviewed
Sep 21, 2026
jgerh
left a comment
jgerh
left a comment
Contributor
There was a problem hiding this comment.
Completed tech pubs review of docs/model-coverage/vlm/thudm/glm-5-3-flash.mdx and provided a few copyedits. Otherwise, looks great.
| | **Parameters** | 320B total, 18B active | | ||
| | **Decoder** | 45 layers: 34 KDA and 11 KPool-DSA layers | | ||
| | **Experts** | 288 routed experts, top-8 routing, plus one shared expert | | ||
| | **Context length** | 1,048,576 in the checkpoint configuration; validated here at 2,048 and 4,096 tokens | |
Contributor
There was a problem hiding this comment.
Suggested change
| | **Context Length** | 1,048,576 in the checkpoint configuration; validated here at 2,048 and 4,096 tokens | |
Comment on lines
112
to
114
| <Note> | ||
|
|
||
| Use the [Slurm Launcher Guide](/job-launchers/slurm-cluster) to configure the |
Contributor
There was a problem hiding this comment.
Suggested change
| <Note> | |
| Use the [Slurm Launcher Guide](/job-launchers/slurm-cluster) to configure the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the GLM-5.3-Flash model-coverage page, both verified against the repository at
9a4632347323fbfee9ba1ae1a323669ef74fc5fb.1. The documented install command does not run.
Tested with
uv 0.11.20.vlm-mediais a declared extra (pyproject.toml:179) and is already covered by--all-extras, so dropping the redundant flag makes the command run as written.2. The cited transformers pin is stale.
The page states the implementation "runs on the repository's pinned
transformers==5.12.1". The pin moved to5.15.1in #3781;pyproject.toml:89anduv.lockboth now read5.15.1.Both changes are one line each. Happy to split them if you would prefer separate PRs.
I have a follow-up question about the Hugging Face logit parity section on the same page, which I will file separately as an issue rather than fold into this PR.