-
Notifications
You must be signed in to change notification settings - Fork 0
Fix FK computation whenmur != muf
#239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
felixhekhorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Before merging this, please check that it can indeed by used for herajet and that it works for a few other datasets (beyond the ones in the tests) for theory 4.1. Possibly with N3LO DIS grids. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of possible bugs fixed by this:
- HERAjet @kamillaurent
- HERA @ NNLO @andrpie (but actually it was just version differences)
- NMC @ NNLO (this was fixed by not optimizing)
|
I did check HERAjet a few days back and it works. The other bug (related to |
|
This now completely solves all the issues we've been seeing. Before merging, I'd like to double check again the NMC, could someone please provide the grids and EKOs for one of the NMC datasets? |
This error was introduced after an EKO update. Before that change, the scale$\mu_R^2$ was correctly used to compute $\alpha_s$ :
pineko/src/pineko/evolve.py
Lines 400 to 408 in e88a4a2
And this is the reason why people managed to compute FK tables for H1 Jets before (see eg. vp-report).
This PR adds a quick fix to this issue (which is a bit ad-hoc). Ideally, I'd say,
mur2grid(mur2, nf)should be part of the operator cards but this would require an update of EKO which is not ideal. At least with this fix, the EKO can be correctly convolve with the Grid.TODO: