Move the scale variation check to the operator card creation #238
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixhekhorn
approved these changes
Oct 29, 2025
scarlehoff
force-pushed
the
move_the_check_to_the_op
branch
from
4191822 to
4375fad
Compare
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
scarlehoff
force-pushed
the
move_the_check_to_the_op
branch
from
4375fad to
0d12492
Compare
Member
Author
|
@evagroenendijk I needed to remove the delete to be able to combine different fktables. Not sure whether we just forgot to remove it somehow from your branch or something? (I had rebased this on top of main so it should include your changes) |
Member
Author
|
@evagroenendijk can I merge this? (i.e., is the removal of the delete ok?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of waiting for hours for the EKO to be produced only to find out at the end that you couldn't use it.