Conversation
These 3 files have been changed for " I'm feeling lucky button in chrome extension"
|
@PaliwalSparsh is travelling maybe @djmgit should have a look at it if he's available? @spidervamsi It might take some time to review :P |
|
I'll wait for him.Thank you so much @abhsag24 :) |
There was a problem hiding this comment.
@spidervamsi Thanks for the PR. Please see the comments below:
Please remove the two extra empty lines which you have added in popup.css.
Please remove the whitespace you have added before 'var index' in popup.js. Do try to maintain a consistent indentation.
You have referred a file named indexStuff.js in popup.html which is not present in the repo.
If i am not wrong your PR deals with adding I am feeling lucky button, however I could not relate the PR title with the change you have made. Moreover issue #35 deals with the same task. So it would be nice if you refer that issue in your PR. You can checkout CONTRIBUTING.md to see how to refer a issue
Thanks for the PR :)
|
@djmgit thanks for reviewing. @spidervamsi Thanks for the PR. As @djmgit specified this is issue #35 . The bug had As i can see from the changes you made, Next and the most important thing you would want to do is search for a way through which we can create a URL that lands us on the first result of the google results query (ie actual work that I'm feeling lucky does). Once you find the URL that would be used to perform this work, add the search query to it and then add this whole to the button. That would do the work. I hope you would be able to make it work. Again thanks for the work. |
These 3 files have been changed for " I'm feeling lucky button in chrome extension"