Open
Conversation
We (NDSPCDSP) for example don't use DynamoDB, EBS volumes or ParameterStore,
so we have no need for those backup plans, and it seems silly to create
them no matter what.
So to make sure they don't gets created, I want/need to set:
```
module "source" {
[...]
backup_plan_config = { "enable": false }
backup_plan_config_dynamodb = { "enable": false }
backup_plan_config_ebsvol = { "enable": false }
backup_plan_config_parameter_store = { "enable": false }
}
```
All the other `backup_plan_config_*` resources had a `count` to
create them or not, but not the "main" one, so add that. That lead
to the resources being an array, so make sure they're `moved`
automatically.
It also required *all* options in the variables to be `optional()`,
which should (!?) be ok, since there's defaults.
HOWEVER, the `default` is only used if/when the variable is completely
unset! NOT if/when some values are missing. As in, TF won't substitute
empty/unset values with one from the `default`.
That unfortunately lead to those three values required (`selection_tag`,
`compliance_resource_types` and `rules` in the case of the "main" config)
can't be required anymore. Because they have defaults, there's no way
to check (`validation {}`) if they're set or not. Because they always will,
wether `enable` is `true` or `false` :(.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (CDS-NDSP) for example don't use DynamoDB, EBS volumes or ParameterStore, so we have no need for those backup plans, and it seems silly to create them no matter what.
So to make sure they don't gets created, I want/need to set:
All the other
backup_plan_config_*resources had acountto create them or not, but not the "main" one, so add that. That lead to the resources being an array, so make sure they'removedautomatically.It also required all options in the variables to be
optional(), which should (!?) be ok, since there's defaults.HOWEVER, the
defaultis only used if/when the variable is completely unset! NOT if/when some values are missing. As in, TF won't substitute empty/unset values with one from thedefault.That unfortunately lead to those three values required (
selection_tag,compliance_resource_typesandrulesin the case of the "main" config) can't be required anymore. Because they have defaults, there's no way to check (validation {}) if they're set or not. Because they always will, wetherenableistrueorfalse:(.Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.