Skip to content

LZVS-2611: Fix several issues and add SNS enhancement#109

Open
michelfasen-nhs wants to merge 12 commits intomainfrom
LZVS-2611
Open

LZVS-2611: Fix several issues and add SNS enhancement#109
michelfasen-nhs wants to merge 12 commits intomainfrom
LZVS-2611

Conversation

@michelfasen-nhs
Copy link
Copy Markdown

@michelfasen-nhs michelfasen-nhs commented Feb 9, 2026

Description

  • Modified modules/aws-backup-source/backup_plan.tf and modules/aws-backup-source/backup_restore_testing.tf
    • Add environment_name tag to all Backup Plans to prevent Backup Framework reporting account as not compliant
    • Fix Aurora selection plan which was ignoring non-default value tag
  • Modified modules/aws-backup-destination/parameter_store_kms.tf
    • Use "var.name_prefix" for KMS Alias to allow multiple source accounts to backup to one destination account
  • Modified modules/aws-backup-source/backup_notification.tf and modules/aws-backup-source/sns.tf
    • Add support for additional SNS subscribers to support Lambda, SQS, HTTP etc.

Non-breaking changes unless you directly point to the Parameter Store KMS Alias outside this Backup Template.

@michelfasen-nhs michelfasen-nhs self-assigned this Feb 9, 2026
@michelfasen-nhs michelfasen-nhs marked this pull request as ready for review February 9, 2026 13:44
@michelfasen-nhs michelfasen-nhs requested a review from a team February 9, 2026 13:44
@michelfasen-nhs michelfasen-nhs changed the title LZVS-2611: Fix framework compliance and destination KMS alias LZVS-2611: Fix several issues and add SNS enhancement Feb 26, 2026
@TurboNHS
Copy link
Copy Markdown

@michelfasen-nhs It would be nice if you could separate these two into two separate PRs.

I'm somewhat interested in your SNS stuff, but I'm also already doing some of what you're doing (especially modules/aws-backup-source/backup_restore_testing.tf).

Not saying mine's better than yours, and I'm perfectly fine on rebasing mine if yours get merged first, but it might be .. "quicker" (!?) to have it/"them" approved and merged if there's two separate .. "things" being worked on.. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants