CCM-15562: Add campaignId check to update routing config#899
Open
m-salaudeen wants to merge 31 commits intomainfrom
Open
CCM-15562: Add campaignId check to update routing config#899m-salaudeen wants to merge 31 commits intomainfrom
m-salaudeen wants to merge 31 commits intomainfrom
Conversation
alexnuttall
reviewed
Apr 8, 2026
alexnuttall
reviewed
Apr 8, 2026
alexnuttall
reviewed
Apr 8, 2026
alexnuttall
reviewed
Apr 8, 2026
nicki-nhs
reviewed
Apr 10, 2026
nicki-nhs
reviewed
Apr 10, 2026
nicki-nhs
reviewed
Apr 10, 2026
nicki-nhs
reviewed
Apr 10, 2026
nicki-nhs
reviewed
Apr 10, 2026
nicki-nhs
reviewed
Apr 10, 2026
nicki-nhs
reviewed
Apr 10, 2026
Contributor
|
can you make sure you update the description on the PR please |
nicki-nhs
reviewed
Apr 20, 2026
nicki-nhs
reviewed
Apr 20, 2026
nicki-nhs
reviewed
Apr 20, 2026
nicki-nhs
reviewed
Apr 20, 2026
…CCM-16467_filter-templates-by-campaign
nicki-nhs
reviewed
Apr 22, 2026
nicki-nhs
reviewed
Apr 22, 2026
nicki-nhs
reviewed
Apr 22, 2026
nicki-nhs
previously approved these changes
Apr 22, 2026
…CCM-16467_filter-templates-by-campaign
Contributor
|
fairly confident your tests here https://github.com/NHSDigital/nhs-notify-internal/actions/runs/24780369492 are failing because the campaign IDs in the component and e2e tests dont match between the templates being added and the routing configs they are being added to |
…CCM-15562_matching_campaign_id_api
c0d1182 to
89155ed
Compare
10 tasks
alexnuttall
previously approved these changes
Apr 27, 2026
f1d9077 to
f9f428a
Compare
Base automatically changed from
feature/CCM-16467_filter-templates-by-campaign
to
main
April 27, 2026 10:07
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The implementation plan in this ticket is to make sure that when letter template update is happening, a check is made to make sure that the campaignId in the template is the same as the campaignId in the routing config.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.