Open
Conversation
|
|
||
| const lockNumberValidation = $LockNumber.safeParse(lockNumberRaw); | ||
|
|
||
| if (!lockNumberValidation.success) { |
Contributor
There was a problem hiding this comment.
why do we need to pre-validate the lock number separately? the dynamodb call is already checking it's the right value
Contributor
Author
There was a problem hiding this comment.
I'm not sure why this pattern was established - I guess because of unwillingness to return a 409 if lock number is completely invalid. I think that would be preferable though
chris-elliott-nhsd
previously approved these changes
Mar 6, 2026
alexnuttall
dismissed
chris-elliott-nhsd’s stale review
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.