Skip to content

CCM-13492: initial spinner#865

Merged
alexnuttall merged 366 commits intomainfrom
feature/13492-initial-spinner
Mar 10, 2026
Merged

CCM-13492: initial spinner#865
alexnuttall merged 366 commits intomainfrom
feature/13492-initial-spinner

Conversation

@alexnuttall
Copy link
Contributor

@alexnuttall alexnuttall commented Mar 2, 2026

Description

PR to add a page level spinner when the initial render is pending. This is only displayed when viewing the page within 20s of template creation.

Playwright tests cover the spinner, but not spinner timeout. This will be covered in e2e and/or system tests.

Polling works by calling router.refresh which rerenders server components but preserves client state. I think this might also work for the per-tab renders

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@alexnuttall alexnuttall marked this pull request as ready for review March 3, 2026 14:41
@alexnuttall alexnuttall force-pushed the feature/13492-initial-spinner branch from 86a9772 to 5ec67f7 Compare March 4, 2026 13:46
@alexnuttall alexnuttall closed this Mar 4, 2026
@alexnuttall alexnuttall reopened this Mar 4, 2026
@alexnuttall alexnuttall closed this Mar 4, 2026
@alexnuttall alexnuttall reopened this Mar 4, 2026
@alexnuttall alexnuttall merged commit ee585f8 into main Mar 10, 2026
45 checks passed
@alexnuttall alexnuttall deleted the feature/13492-initial-spinner branch March 10, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants