CCM-17047 Add client , campaign and supplier name to Grafana dashboard#543
Open
Vlasis-Perdikidis wants to merge 6 commits intomainfrom
Open
CCM-17047 Add client , campaign and supplier name to Grafana dashboard#543Vlasis-Perdikidis wants to merge 6 commits intomainfrom
Vlasis-Perdikidis wants to merge 6 commits intomainfrom
Conversation
| const tasks = event.Records.map(async (record) => { | ||
| let supplier = "unknown"; | ||
| let priority = "unknown"; | ||
| let letterEvent: PreparedEvents | undefined; |
Contributor
There was a problem hiding this comment.
Can letterEvent ever be undefined, with the "as PreparedEvents" assertion below?
Maybe could be simplified to
Suggested change
| let letterEvent: PreparedEvents | undefined; | |
| let letterEvent: PreparedEvents; |
Comment on lines
+28
to
+33
| ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js.map:ipv4:4 | ||
| ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:63 | ||
| ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:62 | ||
| ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:60 | ||
| ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:59 | ||
| ff889d4c3f29da4468ecf1f05f467fe84d35b2a1:lambdas/supplier-mock/.aws-sam/build/SupplierMockFunction/index.js:ipv4:24 |
Contributor
There was a problem hiding this comment.
Looks like this has already gone in to main?
| emitSupCampaignClientMetric( | ||
| letterEvent, | ||
| supplier, | ||
| "supplier_Campaign_Client", |
Contributor
There was a problem hiding this comment.
Is this supposed to be a "constant" value?
| function emitSupCampaignClientMetric( | ||
| letterEvent: PreparedEvents, | ||
| supplier: string, | ||
| status: string, |
Contributor
There was a problem hiding this comment.
Naming Q: Is this status as in supplier status? Looks like it's used for metric key?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.