CCM-16035 Update deploy worfklow#536
Conversation
|
|
||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4 |
There was a problem hiding this comment.
Are we sure we want to get rid of deploying these pages? Discussion was that we are already doing this on publish, but publish doesn't deploy the docs to github pages - unless we don't want to do that anymore
There was a problem hiding this comment.
We configure the pages and then upload the compiled packages
I'll take another look to see if there's a missing step - if there is I would probably attach it to either the release or main pipeline publish rather than the deploy here
So in either case I think this is the wrong place for this to live
| type: choice | ||
| required: true | ||
| default: internal-dev | ||
| options: |
There was a problem hiding this comment.
Do we still use ref?
There was a problem hiding this comment.
we might and it's still technically supported
| default: dev | ||
| options: | ||
| - dev | ||
| - nonprod |
There was a problem hiding this comment.
Currently there's no approvals step for nonprod deployments (as in prod). If I accidentally deploy something to nonprod via https://github.com/NHSDigital/nhs-notify-internal/actions/workflows/dispatch-deploy-static-notify-supplier-api-env.yaml (or this new deploy worflow) and it passes, it will be deployed...
| type: choice | ||
| required: true | ||
| default: internal-dev | ||
| options: |
There was a problem hiding this comment.
we might and it's still technically supported
| description: "Deploy APIM proxy" | ||
| type: boolean | ||
| required: false | ||
| default: false |
There was a problem hiding this comment.
I think the defaults should be to deploy the backend and the proxy - in most circumstances we would want both components to be in sync
It would only be in some sort of error recovery scenario that we would patch just the one side
|
|
||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4 |
There was a problem hiding this comment.
We configure the pages and then upload the compiled packages
I'll take another look to see if there's a missing step - if there is I would probably attach it to either the release or main pipeline publish rather than the deploy here
So in either case I think this is the wrong place for this to live
3 participants
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.