CCM-16444: Config seeding for dynamic envs#532
Open
nhsd-david-wass wants to merge 9 commits intomainfrom
Open
Conversation
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
2 times, most recently
from
9b04a23 to
3f66c94
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
2 times, most recently
from
551f2e2 to
777b1e0
Compare
m-houston
reviewed
Apr 23, 2026
m-houston
reviewed
Apr 23, 2026
m-houston
reviewed
Apr 23, 2026
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
3 times, most recently
from
23aa898 to
de7cb87
Compare
| runId: "${{ github.run_id }}" | ||
| buildSandbox: true | ||
| releaseVersion: ${{ github.head_ref || github.ref_name }} | ||
| populate-config: |
Contributor
There was a problem hiding this comment.
Minor, but populate-config could go before artefact-proxies, so we have the backend stuff done first?
| { | ||
| "channelType": "LETTER", | ||
| "dailyCapacity": 500000, | ||
| "id": "supplier1", |
Contributor
There was a problem hiding this comment.
Currently we use "TestSupplier1" for component tests https://github.com/NHSDigital/nhs-notify-supplier-api/blob/main/tests/config/global-setup.ts#L16 - so we might want to align this if this is to support testing?
Contributor
Author
There was a problem hiding this comment.
There's going to be another bit of work to migrate from the current suppliers table to thie new 'supplier-config' table when we'll do this
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
2 times, most recently
from
ee81c02 to
8f124b7
Compare
nhsd-david-wass
changed the title
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
from
c39e267 to
60c6664
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
from
60c6664 to
1fda0c9
Compare
m-houston
requested changes
Apr 27, 2026
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
from
9152a56 to
2496250
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-16444-Config-Seeding-For-Dynamic-Envs
branch
from
2496250 to
89c29a9
Compare
m-houston
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.