CCM-16073 - Split clients infra into its own component#168
Closed
rhyscoxnhs wants to merge 9 commits intofeature/CCM-16073from
Closed
CCM-16073 - Split clients infra into its own component#168rhyscoxnhs wants to merge 9 commits intofeature/CCM-16073from
rhyscoxnhs wants to merge 9 commits intofeature/CCM-16073from
Conversation
rhyscoxnhs
force-pushed
the
feature/CCM-16073-split-infra
branch
from
72faa62 to
3d7a402
Compare
aidenvaines-cgi
requested changes
Apr 29, 2026
Contributor
aidenvaines-cgi
left a comment
aidenvaines-cgi
left a comment
There was a problem hiding this comment.
Not really sure why we have callbacks-client, callbacks, AND cbc
Contributor
There was a problem hiding this comment.
im not sure as a symlink this is a good idea
Contributor
There was a problem hiding this comment.
this seems a bit messy and is not a pattern we have elsewhere
aidenvaines-cgi
requested changes
Apr 29, 2026
| --overrideProjectName "nhs" \ | ||
| --overrideRoleName "nhs-main-acct-client-callbacks-github-deploy" \ | ||
| --overrides "branch_name=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" | ||
| pr-create-dynamic-environment-clients: |
Contributor
There was a problem hiding this comment.
i was expecting this just to be changes not entirely new code?
Base automatically changed from
feature/CCM-16073-rate-limit
to
feature/CCM-16073
April 29, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.