Skip to content

[PRMP-1447] Implement "Soft Delete" Logic for UpdateStatusUserRestriction Lambda#1156

Open
steph-torres-nhs wants to merge 18 commits intomainfrom
PRMP-1447
Open

[PRMP-1447] Implement "Soft Delete" Logic for UpdateStatusUserRestriction Lambda#1156
steph-torres-nhs wants to merge 18 commits intomainfrom
PRMP-1447

Conversation

@steph-torres-nhs
Copy link
Contributor

@steph-torres-nhs steph-torres-nhs commented Mar 6, 2026 •
edited
Loading

Overview

Jira ticket: PRMP-1447

Description

Creation of service and handler to handle soft delete of user restrictions

Context

User Restrictions feature

Checklist

Tasks for all changes:

NogaNHS
NogaNHS reviewed Mar 6, 2026
View reviewed changes
SWhyteAnswer
SWhyteAnswer reviewed Mar 6, 2026
View reviewed changes
lambdas/handlers/user_restrictions/update_status_user_restriction_handler.py Outdated

return ApiGatewayResponse(
status_code=204,
body=json.dumps("No content"),
Copy link
Contributor

@SWhyteAnswer SWhyteAnswer Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a body is needed right?

Copy link
Contributor Author

@steph-torres-nhs steph-torres-nhs Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah doesn't use it

NogaNHS
NogaNHS reviewed Mar 6, 2026
View reviewed changes
SWhyteAnswer
SWhyteAnswer reviewed Mar 6, 2026
View reviewed changes
lambdas/utils/exceptions.py Outdated
pass


class UserRestrictionNotFoundException(Exception):
Copy link
Contributor

@SWhyteAnswer SWhyteAnswer Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't being used

Copy link
Contributor Author

@steph-torres-nhs steph-torres-nhs Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

SWhyteAnswer
SWhyteAnswer reviewed Mar 6, 2026
View reviewed changes
lambdas/enums/lambda_error.py Outdated
"message": "Malformed user restriction model error",
}

UserRestrictionNotFound = {
Copy link
Contributor

@SWhyteAnswer SWhyteAnswer Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't being used

Copy link
Contributor Author

@steph-torres-nhs steph-torres-nhs Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

SWhyteAnswer
SWhyteAnswer previously approved these changes Mar 6, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SWhyteAnswer SWhyteAnswer SWhyteAnswer approved these changes

@NogaNHS NogaNHS NogaNHS approved these changes

@SteveMahoneyNHS SteveMahoneyNHS Awaiting requested review from SteveMahoneyNHS SteveMahoneyNHS is a code owner automatically assigned from NHSDigital/access-store

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steph-torres-nhs @SWhyteAnswer @NogaNHS