[PRMP-1408] DocumentReference history endpoint functionality by kamenbachvarov-nhs · Pull Request #1144 · NHSDigital/national-document-repository

kamenbachvarov-nhs · 2026-03-02T13:09:54Z

Overview

Jira ticket: PRMP-1408

Description

/DocumentReference/{id}/_history endpoint logic (handler + (fhir) service separation)
adapted authoriser to accept "_" (underscore) in endpoint paths
adapted the core lambda layer to include the new lambda deployment
feature flagged behind versionHistory flag
adjusted the doc_ref_pattern in authoriser service to include the new endpoint

Checklist

Tasks for all changes:

1. I have linked this PR to its Jira ticket.
2. ~~I have run git pre-commits.~~ (WIP)
3. I have added and/or updated relevant tests.
4. I have updated relevant documentation.
5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
6. I have successfully deployed this change to a sandbox and witnessed unit, e2e and smoke tests passing:
- 6a. Deploy - Sandbox - workflow run - 22580045616
- 6b. SANDBOX Full- Deploy feature branch to sandbox - workflow run - 22581283158

Additional tasks for UI changes (delete if not applicable):

1. I have added evidence (to this PR) e.g. screenshots/gifs of all visual changes.

happy path

wrong id

user is not custodian

version history feature flag not enabled

NogaNHS · 2026-03-04T11:30:56Z

lambdas/services/get_fhir_document_reference_history_service.py

+        entries = []
+
+        for doc_ref in items:
+            self.check_if_doc_ref_belongs_to_patient(doc_ref, nhs_number)


Why are we checking this here? what is the risk?

moved this check as nhs filter - created it to cover for a scenario where user enters correct s3filekey but its reference is for a different patient

NogaNHS · 2026-03-04T11:31:35Z

lambdas/services/get_fhir_document_reference_history_service.py

+            table_name=self.lg_table,
+            search_key="S3FileKey",
+            search_condition=s3_file_key,
+            index_name="S3FileKeyIndex",


Can you add a filter to check the nhs number here?

NogaNHS · 2026-03-04T11:32:09Z

lambdas/services/get_fhir_document_reference_history_service.py

+            doc_ref["LastUpdated"] = int(doc_ref["LastUpdated"])
+            doc_ref["FileSize"] = int(doc_ref["FileSize"])


is it not an int already?

used to give me a model error, does not do that after refactoring so removed this casting

they are decimals

github-actions · 2026-03-11T17:27:12Z

Code security issues found

View full details here.

sonarqubecloud · 2026-03-11T17:30:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kamenbachvarov-nhs had a problem deploying to development March 2, 2026 13:10 — with GitHub Actions Failure

lillie-dae previously approved these changes Mar 2, 2026

View reviewed changes

kamenbachvarov-nhs force-pushed the PRMP-1408 branch from 3877ebf to c1cf854 Compare March 2, 2026 13:26

kamenbachvarov-nhs had a problem deploying to development March 2, 2026 13:26 — with GitHub Actions Failure

kamenbachvarov-nhs temporarily deployed to development March 2, 2026 14:50 — with GitHub Actions Inactive

kamenbachvarov-nhs temporarily deployed to development March 2, 2026 14:51 — with GitHub Actions Inactive

NogaNHS reviewed Mar 4, 2026

View reviewed changes

kamenbachvarov-nhs added 25 commits March 11, 2026 17:10

WIP

372b671

update deploy workflow

125924e

WIP

e7e5278

env variables

ca9dd47

WIP query table

f4a930c

auth regex match fix

6e47bcd

WIP

2abd214

bundle response and error handling

4eadcf6

non final version restriction and error log fix

4342f44

handler tests

faa1350

services UT

95a1531

add test file size

63f8636

catch OdsErrorException

7615d87

refactor history bundle

15f3b24

pr comments

5ef106d

export constants

164dab4

refactor nhs number check

9f9a614

fix import

e3d3728

clean up

a7b548b

fix ut

6f4667f

attempt to fix sonar issue

17c9628

sonnar issue 2

dfa4148

remove cast

1902a71

remove my precommit

9b11017

error clean up

c500f70

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PRMP-1408] DocumentReference history endpoint functionality#1144

[PRMP-1408] DocumentReference history endpoint functionality#1144
kamenbachvarov-nhs wants to merge 25 commits intomainfrom
PRMP-1408

kamenbachvarov-nhs commented Mar 2, 2026 •

edited

Loading

Uh oh!

NogaNHS Mar 4, 2026

Uh oh!

kamenbachvarov-nhs Mar 11, 2026

Uh oh!

NogaNHS Mar 4, 2026

Uh oh!

kamenbachvarov-nhs Mar 11, 2026

Uh oh!

NogaNHS Mar 4, 2026

Uh oh!

kamenbachvarov-nhs Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		doc_ref["LastUpdated"] = int(doc_ref["LastUpdated"])
		doc_ref["FileSize"] = int(doc_ref["FileSize"])

Conversation

kamenbachvarov-nhs commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Description

Checklist

Uh oh!

NogaNHS Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

kamenbachvarov-nhs Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

NogaNHS Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

kamenbachvarov-nhs Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

NogaNHS Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

kamenbachvarov-nhs Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 11, 2026

Code security issues found

Uh oh!

sonarqubecloud bot commented Mar 11, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kamenbachvarov-nhs commented Mar 2, 2026 •

edited

Loading

kamenbachvarov-nhs Mar 11, 2026 •

edited

Loading