[PRMP-1505] Update ODS code report to include created and last updated by PedroSoaresNHS · Pull Request #1135 · NHSDigital/national-document-repository

PedroSoaresNHS · 2026-02-26T09:57:05Z

Overview

Jira ticket: (https://nhsd-jira.digital.nhs.uk/browse/PRMP-1505)

Description

Update ODS code report to include created and last updated

Context

We need created and last updated column in ODS report for compliance reasons

Checklist

Tasks for all changes:

1. I have linked this PR to its Jira ticket.
2. ~~I have run git pre-commits.~~ (WIP)
3. I have added and/or updated relevant tests.
4. I have updated relevant documentation.
5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:
- 6a. Deploy - Sandbox - workflow run - TBC
- 6b. SANDBOX Full- Deploy feature branch to sandbox - workflow run - TBC

lambdas/services/ods_report_service.py

# Conflicts: # lambdas/models/fhir/R4/fhir_document_reference.py # lambdas/services/staged_document_review_processing_service.py # lambdas/tests/unit/models/fhir/R4/test_fhir_document_reference.py # lambdas/tests/unit/services/test_bulk_upload_service.py # lambdas/tests/unit/services/test_staged_document_review_processing_service.py

lambdas/services/ods_report_service.py

Co-authored-by: Mohammad Iqbal <127403145+MohammadIqbalAD-NHS@users.noreply.github.com>

NogaNHS · 2026-03-04T13:40:59Z

lambdas/services/ods_report_service.py

-            report_type=ReportType.REVIEW,
        )

+    def create_and_save_review_report(


What is the reason behind this split? this is now duplicating the code

it is duplication a small bit of code, but makes the logic simpler.
Instead of passing a variable to then be used in an If statement in the following method

lambdas/services/ods_report_service.py

github-actions · 2026-03-05T09:55:21Z

Code security issues found

View full details here.

sonarqubecloud · 2026-03-05T09:59:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PedroSoaresNHS added 4 commits February 25, 2026 11:31

[PRMP-1505] added created and last_updated column to ods report

b67010e

[PRMP-1505] small fixes

410bcb1

[PRMP-1505] small fixes

a4cb5ed

Merge remote-tracking branch 'origin/main' into PRMP-1505

fb88c62

PedroSoaresNHS had a problem deploying to development February 26, 2026 09:57 — with GitHub Actions Failure

PedroSoaresNHS marked this pull request as ready for review February 26, 2026 09:57

PedroSoaresNHS requested review from a team as code owners February 26, 2026 09:57

PedroSoaresNHS requested a review from SteveMahoneyNHS February 26, 2026 09:57

[PRMP-1505] added extra unit tests

2aad23a

PedroSoaresNHS had a problem deploying to development February 26, 2026 10:07 — with GitHub Actions Failure

[PRMP-1505] format

4c9474b

PedroSoaresNHS had a problem deploying to development February 26, 2026 10:09 — with GitHub Actions Failure

chrisbloe changed the title ~~[PRMP-1505]-Update ODS code report to include created and last updated~~ [PRMP-1505] Update ODS code report to include created and last updated Feb 26, 2026

Merge remote-tracking branch 'origin/main' into PRMP-1505

8665645

PedroSoaresNHS had a problem deploying to development February 26, 2026 10:56 — with GitHub Actions Failure

MohammadIqbalAD-NHS reviewed Mar 2, 2026

View reviewed changes

lambdas/services/ods_report_service.py Outdated Show resolved Hide resolved