NIAD-3432: Skeleton processing service now removes leading _ before performing XPath query#1257
Merged
chiaramapellimt merged 2 commits intomainfrom Apr 7, 2026
Merged
NIAD-3432: Skeleton processing service now removes leading _ before performing XPath query#1257chiaramapellimt merged 2 commits intomainfrom
chiaramapellimt merged 2 commits intomainfrom
Conversation
…erforming XPath query
…erforming XPath query
|
Looks good. All 2 mutations in this change were killed.
|
|
Images built and published to ECR using a Build Id of PR-1011-df2a18d |
Jonopono123
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This fix relates to this ticket: https://nhse-dsic.atlassian.net/browse/NIAD-3432
When processing large messages with a skeleton attachment, the adaptor takes the skeleton document ID from the ebXML reference and uses it to search for the matching node in the payload XML. However, EMIS and SystmOne both prefix their ebXML document IDs with a leading underscore, while the same ID appears without the underscore in the payload XML. This mismatch meant the XPath query never found a matching node, returning null and causing the NullPointerException and subsequent LARGE_MESSAGE_GENERAL_FAILURE.
Why
Strip the leading underscore from the document ID before executing the XPath query. This is a one-line change in SkeletonProcessingService.java and is safe for messages where the document ID has no leading underscore, as the operation is a no-op in that case.
Type of change
Please delete options that are not relevant.
Checklist: