NIAD-3432: Improved error handling when processing skeleton message#1256
Merged
chiaramapellimt merged 2 commits intomainfrom Mar 24, 2026
Merged
NIAD-3432: Improved error handling when processing skeleton message#1256chiaramapellimt merged 2 commits intomainfrom
chiaramapellimt merged 2 commits intomainfrom
Conversation
|
Images built and published to ECR using a Build Id of PR-1008-dccf5a3 |
chiaramapellimt
force-pushed
the
NIAD-3432
branch
3 times, most recently
from
5409a2b to
cb11a19
Compare
chiaramapellimt
force-pushed
the
NIAD-3432
branch
4 times, most recently
from
e770f60 to
5235251
Compare
NIAD-3435: Documentation improvement (#1254) * Documentation improvement * README.md improvement * README.md letter capitalization improvements * README.md letter capitalization improvements * REDACTIONS.md enhancements * getting-started-with-windows.md docs update * GPC Consumer version adjustment Improved error handling when processing skeleton message NIAD-3435: Documentation improvement (#1254) * Documentation improvement * README.md improvement * README.md letter capitalization improvements * README.md letter capitalization improvements * REDACTIONS.md enhancements * getting-started-with-windows.md docs update * GPC Consumer version adjustment
chiaramapellimt
force-pushed
the
NIAD-3432
branch
from
5235251 to
cd8bce3
Compare
|
Looks good. All 2 mutations in this change were killed.
|
ORybak5
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added a null check in SkeletonProcessingService when searching for a payload node matching the skeleton document ID, throwing a descriptive IllegalArgumentException instead of a NullPointerException.
Why
EMIS messages were failing with an uninformative NullPointerException, making the root cause difficult to diagnose from logs. Related ticket: https://nhse-dsic.atlassian.net/browse/NIAD-3432.
Type of change
Please delete options that are not relevant.
Checklist: