VED-1088-Validate-system-URL-in-patient-identifier-resource#1272
Open
amarauzoma wants to merge 2 commits intomasterfrom
Open
VED-1088-Validate-system-URL-in-patient-identifier-resource#1272amarauzoma wants to merge 2 commits intomasterfrom
amarauzoma wants to merge 2 commits intomasterfrom
Conversation
Thomas-Boyle
reviewed
Mar 9, 2026
| legacy CSV field name: NHS_NUMBER) exists, then it is 'https://fhir.nhs.uk/Id/nhs-number' | ||
| """ | ||
| field_location = "contained[?(@.resourceType=='Patient')].identifier[0].system" | ||
| predefined_values = [Urls.NHS_NUMBER] |
Contributor
There was a problem hiding this comment.
Pre‑validators still enforce that any Patient identifier if present must use the NHS number.
Thomas-Boyle
reviewed
Mar 9, 2026
| "value" | ||
| ] | ||
| PreValidation.for_string(field_value, field_location, defined_length=10, spaces_allowed=False) | ||
| PreValidation.for_nhs_number(field_value, field_location) |
| create_result = CustomValidationError( | ||
| message="Validation errors: contained[?(@.resourceType=='Patient')].identifier[0].value does not exists" | ||
| message="Validation errors: contained[?(@.resourceType=='Patient')].identifier[?(@.system=='https://fhir.nhs.uk/Id/nhs-number')].value does not exists" | ||
| ) |
Contributor
There was a problem hiding this comment.
would it be better to put this in a function, so its use is clear and it can be re-used?
avshetty1980
requested changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.