Skip to content

[HOTE-1136] test: add stale reminders test coverage#416

Merged
Masha-kainos merged 2 commits intomainfrom
feature/hote-1136/clean-up-stale-reminders-automation
Apr 27, 2026
Merged

[HOTE-1136] test: add stale reminders test coverage#416
Masha-kainos merged 2 commits intomainfrom
feature/hote-1136/clean-up-stale-reminders-automation

Conversation

@Masha-kainos
Copy link
Copy Markdown
Contributor

Description

This PR adds a test coverage for stale reminders.

Context

This work ensures that key behaviour is validated and supports HOTE‑1136.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copilot AI review requested due to automatic review settings April 27, 2026 15:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

Lambdas Coverage Report

Lines Statements Branches Functions
Coverage: 97%
97.99% (2052/2094) 91.46% (579/633) 96.37% (346/359)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

UI Coverage Report

Lines Statements Branches Functions
Coverage: 96%
96.32% (5927/6153) 88.4% (724/819) 88.44% (222/251)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Playwright API test coverage to verify that “stale” scheduled order status reminders are cancelled when an order progresses to a received state, supporting HOTE‑1136.

Changes:

  • Extend the Order Reminders API spec to create a second order and assert reminder cancellation after a status change to received-at-lab.
  • Update the test Reminder model status union to include the CANCELLED status.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/tests/api/OrderRemindersTest.spec.ts Adds a new API test that drives reminder dispatch then verifies stale scheduled reminders are cancelled after a received status update.
tests/models/TestReminder.ts Expands ReminderStatusCode to include the CANCELLED status used by the new test assertions.

Comment thread tests/models/TestReminder.ts
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@rgolipally1 rgolipally1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Masha-kainos Masha-kainos merged commit 057b96f into main Apr 27, 2026
13 of 14 checks passed
@Masha-kainos Masha-kainos deleted the feature/hote-1136/clean-up-stale-reminders-automation branch April 27, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants