[HOTE-1211] feat: Refactor DB clients to use latest_order_status view#414
Open
[HOTE-1211] feat: Refactor DB clients to use latest_order_status view#414
Conversation
Lambdas Coverage Report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Lambda DB access to use the existing latest_order_status Postgres view instead of repeating “latest status” subqueries/lateral joins, simplifying queries while preserving behavior.
Changes:
- Update
TestResultDbClient.getResultto filter bylatest_order_statusrather than an inline “latest COMPLETE” subquery. - Update
OrderServiceandOrderDbClientqueries to joinlatest_order_statusfor the current order status. - Update Jest unit tests to match the revised SQL and minor formatting changes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lambdas/src/lib/db/test-result-db-client.ts | Uses latest_order_status to require the order be COMPLETE before returning the latest result. |
| lambdas/src/lib/db/test-result-db-client.test.ts | Updates expected SQL and call shapes for the refactored query. |
| lambdas/src/lib/db/order-db.ts | Replaces lateral “latest status” lookup and dedupe check with latest_order_status. |
| lambdas/src/lib/db/order-db.test.ts | Updates expected SQL for the latest_order_status join and NOT EXISTS clause. |
| lambdas/src/lib/db/order-db-client.ts | Joins latest_order_status to return the latest status without ORDER BY/LIMIT on order_status. |
| lambdas/src/lib/db/order-db-client.test.ts | Updates expected SQL to match the new latest_order_status-based query. |
UI Coverage Report
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://nhsd-jira.digital.nhs.uk/browse/HOTE-1211
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.